Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brent] Check for 3rd contamination event. #5115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dracos
Copy link
Member

@dracos dracos commented Aug 15, 2024

For FD-3672
Given info was: "With regards to your contamination events you would need to look for any properties that have had a 3rd, 4th or 5th contamination in the last X months. Use the GetEvents call with EventIDs: 2923, 2924 and 2925."
Am only checking for 3rd, as presumably that means they've had 3, so no need to check 4th/5th.
[skip changelog]

@dracos dracos requested a review from neprune August 15, 2024 12:05
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (2460d7d) to head (8e9339f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5115   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         404      404           
  Lines       31462    31462           
  Branches     4988     4988           
=======================================
  Hits        26008    26008           
- Misses       3975     3976    +1     
+ Partials     1479     1478    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested review from MorayMySoc and removed request for neprune August 16, 2024 08:28
Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants